From a9424cc84bfda0c3a5cba8f782fa93d4f8b9b26a Mon Sep 17 00:00:00 2001 From: Nutcake Date: Fri, 12 May 2023 18:32:54 +0200 Subject: [PATCH] Remove background check interval setting You can give android a rough interval for background tasks but it is in no way guaranteed to be accurate so this setting is getting removed to avoid confusion. --- lib/models/settings.dart | 6 ------ lib/widgets/settings_page.dart | 25 ------------------------- 2 files changed, 31 deletions(-) diff --git a/lib/models/settings.dart b/lib/models/settings.dart index da55744..9f4ee9a 100644 --- a/lib/models/settings.dart +++ b/lib/models/settings.dart @@ -34,18 +34,15 @@ class SettingsEntry { class Settings { final SettingsEntry notificationsDenied; - final SettingsEntry unreadCheckIntervalMinutes; final SettingsEntry lastOnlineStatus; final SettingsEntry lastDismissedVersion; Settings({ SettingsEntry? notificationsDenied, - SettingsEntry? unreadCheckIntervalMinutes, SettingsEntry? lastOnlineStatus, SettingsEntry? lastDismissedVersion }) : notificationsDenied = notificationsDenied ?? const SettingsEntry(deflt: false), - unreadCheckIntervalMinutes = unreadCheckIntervalMinutes ?? const SettingsEntry(deflt: 60), lastOnlineStatus = lastOnlineStatus ?? SettingsEntry(deflt: OnlineStatus.online.index), lastDismissedVersion = lastDismissedVersion ?? SettingsEntry(deflt: SemVer.zero().toString()) ; @@ -53,7 +50,6 @@ class Settings { factory Settings.fromMap(Map map) { return Settings( notificationsDenied: retrieveEntryOrNull(map["notificationsDenied"]), - unreadCheckIntervalMinutes: retrieveEntryOrNull(map["unreadCheckIntervalMinutes"]), lastOnlineStatus: retrieveEntryOrNull(map["lastOnlineStatus"]), lastDismissedVersion: retrieveEntryOrNull(map["lastDismissedVersion"]) ); @@ -71,7 +67,6 @@ class Settings { Map toMap() { return { "notificationsDenied": notificationsDenied.toMap(), - "unreadCheckIntervalMinutes": unreadCheckIntervalMinutes.toMap(), "lastOnlineStatus": lastOnlineStatus.toMap(), "lastDismissedVersion": lastDismissedVersion.toMap(), }; @@ -87,7 +82,6 @@ class Settings { }) { return Settings( notificationsDenied: this.notificationsDenied.passThrough(notificationsDenied), - unreadCheckIntervalMinutes: this.unreadCheckIntervalMinutes.passThrough(unreadCheckIntervalMinutes), lastOnlineStatus: this.lastOnlineStatus.passThrough(lastOnlineStatus), lastDismissedVersion: this.lastDismissedVersion.passThrough(lastDismissedVersion), ); diff --git a/lib/widgets/settings_page.dart b/lib/widgets/settings_page.dart index 1ad9cca..3a77812 100644 --- a/lib/widgets/settings_page.dart +++ b/lib/widgets/settings_page.dart @@ -5,15 +5,6 @@ import 'package:url_launcher/url_launcher.dart'; class SettingsPage extends StatelessWidget { const SettingsPage({super.key}); - static const Map _intervalSelections = { - 5: "5 Minutes", - 15: "15 Minutes", - 30: "30 Minutes", - 60: "1 Hour", - 120: "2 Hours", - 300: "6 Hours", - 600: "12 Hours", - }; @override Widget build(BuildContext context) { @@ -36,22 +27,6 @@ class SettingsPage extends StatelessWidget { initialState: !sClient.currentSettings.notificationsDenied.valueOrDefault, onChanged: (value) async => await sClient.changeSettings(sClient.currentSettings.copyWith(notificationsDenied: !value)), ), - ListTile( - trailing: StatefulBuilder( - builder: (context, setState) { - return DropdownButton( - items: _intervalSelections.keys.map((e) => DropdownMenuItem(value: e, child: Text("${_intervalSelections[e]}"))).toList(), - value: sClient.currentSettings.unreadCheckIntervalMinutes.valueOrDefault, - onChanged: (int? value) async { - ScaffoldMessenger.of(context).showSnackBar(const SnackBar(content: Text("Sorry, this feature is not yet implemented."))); - await sClient.changeSettings(sClient.currentSettings.copyWith(unreadCheckIntervalMinutes: value)); - setState(() {}); - }, - ); - } - ), - title: const Text("Check Interval"), - ), const ListSectionHeader(name: "Other"), ListTile( trailing: const Icon(Icons.logout),