ThatOneJackalGuy/OpenContacts
1
0
Fork 0
Code Issues 3 Pull requests Projects 1 Releases 2 Packages Wiki Activity Actions

Fix unchecked use of BuildContext after await

Browse source 
When using the BuildContext after an asynchronus gap (like when using
await), you always need to check if the context is still mounted before
using it to retrieve objects from the widget tree like with
`ScaffoldMessenger.of(context)`.

Additionally you don't need to use
`.then((value) {})` on a future, if that future is already awaited, you
can simply put any following statements on a new line for better
readability of program flow.
This commit is contained in:
Nutcake 2023-11-11 10:20:55 +01:00
parent 393d71a8bc
commit 7ff98649e9
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/widgets/messages/message_text.dart
View file

@ -14,10 +14,10 @@ class MessageText extends StatelessWidget {
Widget build(BuildContext context) { Widget build(BuildContext context) {
return GestureDetector( return GestureDetector(
onLongPress: () async { onLongPress: () async {
await Clipboard.setData(ClipboardData(text: message.content)).then((_) { await Clipboard.setData(ClipboardData(text: message.content));
ScaffoldMessenger.of(context).showSnackBar( if (context.mounted) {
const SnackBar(content: Text("Copied to clipboard"))); ScaffoldMessenger.of(context).showSnackBar(const SnackBar(content: Text("Copied to clipboard")));
}); }
}, },
child: Column( child: Column(
crossAxisAlignment: CrossAxisAlignment.end, crossAxisAlignment: CrossAxisAlignment.end,